[PATCH] D142833: [RISCV] Move FRM parsing in the assembler to a custom operand parser.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 11:36:44 PST 2023


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:905
+    Op->EndLoc = S;
+    Op->IsRV64 = IsRV64;
+    return Op;
----------------
I suppose you kept this because it was easier to initialize it (vs asserting on access), rather than it actually being needed for a rounding mode operand?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142833/new/

https://reviews.llvm.org/D142833



More information about the llvm-commits mailing list