[PATCH] D142270: [ValueTracking] Add tests for known bits after common BMI pattern (blsmsk/blsi); NFC

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Analysis/ValueTracking/knownbits-bmi-pattern.ll:268
+
+define <2 x i1> @blsmsk_signed_is_false_assume_vec(<2 x i32> %x) {
+; CHECK-LABEL: @blsmsk_signed_is_false_assume_vec(
----------------
FWIW, I would remove all but one of these vector assume tests. They don't really add anything in a world where we just don't support vector assumes. (If we were to add support for them, that would get separate test coverage, and I doubt the canonical pattern we'd require for them would look like what you're doing here -- we'd probably want an assume over an and reduction.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142270/new/

https://reviews.llvm.org/D142270