[PATCH] D142830: [ValueTracking] Improve non-zero tracking of `X` by also searching through `Use(X)` that imply non-zero

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 00:28:47 PST 2023


StephenFan added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2380
 
-  unsigned NumUsesExplored = 0;
+  if (isa<Constant>(V))
+    return false;
----------------
This is a repeat of the above.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2420
+        break;
 
+      case Instruction::And:
----------------
Blank line.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2431
+        if (auto *II = dyn_cast<IntrinsicInst>(OpU)) {
+          switch (II->getIntrinsicID()) {
+          case Intrinsic::abs:
----------------
IIUC, Intrinsic::umin may also imply non-zero. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142830/new/

https://reviews.llvm.org/D142830



More information about the llvm-commits mailing list