[PATCH] D140816: [AVR] Fix incorrect decoding of conditional branch instructions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 28 21:33:01 PST 2023


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp:299
+                                     const MCDisassembler *Decoder) {
+  DenseMap<unsigned, unsigned> brInsts = {
+      {0x000, AVR::BRLOk}, {0x400, AVR::BRSHk}, {0x001, AVR::BREQk},
----------------
A pair array will be more efficient with so few values. You can use `llvm::partition_point` to do bisection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140816/new/

https://reviews.llvm.org/D140816



More information about the llvm-commits mailing list