[PATCH] D142801: [Local][InstCombine] Handle !noundef metadata in combineMetadata

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 28 08:40:05 PST 2023


nikic added a comment.

In D142801#4087926 <https://reviews.llvm.org/D142801#4087926>, @StephenFan wrote:

> In D142801#4087875 <https://reviews.llvm.org/D142801#4087875>, @nikic wrote:
>
>> Shouldn't MD_noundef be added to some more known metadata lists, and in particular also combineMetadataForCSE?
>
> Yes. Do I need to do it all at once? My original thought was to do it step by step.

We need to modify at least one place where DoesKMove is false, otherwise we can't fully test the logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142801/new/

https://reviews.llvm.org/D142801



More information about the llvm-commits mailing list