[PATCH] D141891: [VP][DAGCombiner] Introduce generalized pattern match for vp sdnodes.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 marked an inline comment as done.
fakepaper56 added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1348
+/// Translate this VP Opcode to its corresponding non-VP Opcode.
+std::optional<unsigned> getFunctionOpcodeForVP(unsigned Opcode,
+                                               bool hasFPExcept);
----------------
spatel wrote:
> frasercrmck wrote:
> > I'm not mad about the term "function opcode" - it doesn't sound right to me. I don't have a better suggestion right now though. I'm just commenting this in case other people feel similarly.
> Just a passing comment because it took me 3 tries to translate that "mad" from the American English "angry" to the British English "crazy" and then to "happy". :)
> 
> Possible alternate:
>   getNonPredOpcodeForVP()
> or less contracted:
>   getNonPredicatedOpcodeForVPOpcode()
> or:
>   getBaseOpcodeForVPOpcode()
I prefer `getBaseOpcodeForVPOpcode` since base opcodes also have no effective vector length operands. Does anyone have another idea?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141891/new/

https://reviews.llvm.org/D141891