[PATCH] D141234: [BOLT][Golang support] Core changes

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 28 06:19:43 PST 2023


yota9 marked an inline comment as done.
yota9 added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryContext.h:237
 public:
+  std::vector<std::string> ExtraSectionsNames;
+
----------------
tschuett wrote:
> Do you care about the order? Or is a SmallStringSet sufficient?
Basically you are right here, but this is temp code and one of the problem that was marked by me above - we need to think about refactoring the code that emits extra sections, so probably it would be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141234/new/

https://reviews.llvm.org/D141234



More information about the llvm-commits mailing list