[PATCH] D141650: [VectorUtils] Enhance VFABI demangling API

[Yilong Guo via Phabricator via llvm-commits]

Nuullll added a comment.

Thanks all for the inputs!

In D141650#4084163 <https://reviews.llvm.org/D141650#4084163>, @rsandifo-arm wrote:

> So if it's just a question of whether the AArch64 ABI allows **some** parameterless functions, then like @fpetrogalli says, I think it does/should.  But as it stands, there are some combinations that can be successfully demangled, but would never actually result from a valid `#pragma`.  That includes the combination of a `void` return and no parameter types.

I think we are in agreement that we should allow demangling a paramterless function name for both AArch64 and X86 VFABIs. I'll update the revision.

> I agree with @fpetrogalli (hi!) that the intention probably wasn't to exclude parameterless functions.  I suppose we should extend the grammar rule:
>
>   <parameters> := <parameter> { <parameter> }
>
> to:
>
>   <parameters> := [<parameter> <parameters>]

@rsandifo-arm Will you kindly help clarify this in the AArch64 VFABI document?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141650/new/

https://reviews.llvm.org/D141650