[PATCH] D142797: [X86] Make `prefetchit{0/1}` emit an assembler warning if the operand is not rip-rel

Fri Jan 27 19:59:48 PST 2023

goldstein.w.n added inline comments.

================
Comment at: llvm/test/CodeGen/X86/prefetchi-warning.ll:1
+; -filetype=obj as the warning is from the assembler
+; RUN: llc -filetype=obj -mtriple=x86_64-- -mattr=+prefetchi < %s 2>&1 | FileCheck %s
----------------
pengfei wrote:
> This seems miss a half use case. User may use gas rather than native assembler. Maybe move it to early pass? `X86InstrInfo::verifyInstruction` looks like an ideal place, but it is just for error check.
> This seems miss a half use case. User may use gas rather than native assembler. Maybe move it to early pass? `X86InstrInfo::verifyInstruction` looks like an ideal place, but it is just for error check.

Or pass files assembler by GCC/hand-written to llvm-as...
Imo it makes more sense in `gas` + `llvm-as` than earlier.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142797/new/

https://reviews.llvm.org/D142797