[PATCH] D140666: [InstCombine] combine intersection for inequality icmps

Fri Jan 27 18:19:42 PST 2023

bcl5980 added a comment.

In D140666#4076679 <https://reviews.llvm.org/D140666#4076679>, @inclyc wrote:

> @bcl5980
>
>> Can we merge the code into here? It looks the logic is almost the same.
>
> Looking at it so far, I think we have some misconceptions about merging. Some icmps may be both Mixed and NotMixed? Suggested code changes are assuming icmps are "Mixed" or not, instead, we may encounter `Mask = BMask_Mixed | BMask_NotMixed`  I think that's the fact.

I don't think BMask_Mixed and BMask_NotMixed will happen at the same time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140666/new/

https://reviews.llvm.org/D140666