[PATCH] D142654: [LiveDebugValues] Allow EntryValue with OP_deref expressions

Fri Jan 27 15:52:48 PST 2023

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

In D142654#4087249 <https://reviews.llvm.org/D142654#4087249>, @fdeazeve wrote:

> In D142654#4087149 <https://reviews.llvm.org/D142654#4087149>, @aprantl wrote:
>
>> LGTM, but I agree with Djordje that we should also check that at least LLDB can support this. Maybe someone with access to GDB can comment with another data point.
>> It will be a fun project to mock up an unwinder in lldb/unittests/Expression/DWARFExpression test for this ;-)
>
> Just to make sure we're on the same page, this test is producing virtually the same dwarf as the one I posted previously, which I confirmed to work with LLDB, or is there something fundamentally different that I'm missing here?

If you already confirmed that LLDB can deal with this correctly, that's great!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142654/new/

https://reviews.llvm.org/D142654