[PATCH] D139883: [llvm][CallBrPrepare] add llvm.callbr.landingpad intrinsic

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/callbr-destinations.ll:62
+
+; Validate that callbr landingpad intrinsics do not get merged (via the
+; IntrNoMerge attribute).
----------------
nickdesaulniers wrote:
> jyknight wrote:
> > In the expected pass pipeline, do we simplifycfg after callbrprepare? That seems a bit surprising if so?
> > 
> > (Not that it's wrong to mark it IntrNoMerge, of course.)
> We do not; this is an artifact from when the frontend would produce the intrinsic at which point we would need to guard against SimplifyCFG merging two basic blocks that just contained this intrinsic call.
> 
> I can remove it if you feel that it's unnecessary to retain this guard. WDYT?
Oh I see. No, fine as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139883/new/

https://reviews.llvm.org/D139883