[PATCH] D142782: [AMDGPU] WIP: Add basic support for extended i8 perm matching

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:9766
+/// value of the byte is either constant zero or comes from memory.
+struct ByteProvider {
+  // For constant zero providers Load is set to nullptr. For memory providers
----------------
Can you keep this as a generic utility?


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:9881
+// performed. \p StartingIndex is the originally requested byte of the Or
+static const Optional<ByteProvider>
+calculateByteProvider(SDValue Op, unsigned Index, unsigned Depth,
----------------
Needs to move to std::optional


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142782/new/

https://reviews.llvm.org/D142782