[PATCH] D142747: [Pseudo Probe] Do not instrument EH blocks.

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 12:58:20 PST 2023


modimo added a comment.

In D142747#4087114 <https://reviews.llvm.org/D142747#4087114>, @hoy wrote:

> I'm thinking about llvm/include/llvm/Analysis/CFG.h as a place to put the templated code. WDTY?

Unfortunately (or really fortunately cause it's doing the right thing) llvm/include/llvm/Analysis/CFG.h is a very clean file and I think this code would look a bit out of place. I would fully support a new file being created since it's really not a big deal (check out how small `llvm/lib/Analysis/EHPersonalities.cpp` is) and it'll likely be useful to have in the future as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142747/new/

https://reviews.llvm.org/D142747



More information about the llvm-commits mailing list