[PATCH] D142747: [Pseudo Probe] Do not instrument EH blocks.

Fri Jan 27 12:29:20 PST 2023

modimo added a comment.

In D142747#4087069 <https://reviews.llvm.org/D142747#4087069>, @wenlei wrote:

> In D142747#4086978 <https://reviews.llvm.org/D142747#4086978>, @modimo wrote:
>
>> We've got the same EH-ness propagation code in MFS already: https://reviews.llvm.org/D131824. Consider merging the code?
>
> That diff also used EHPad as seeds for BFS, I thought we only need LandingPads as seeds? Though I think for simple algorithm, having MIR and IR implementation separated is probably fine. I also don't know where to put a merged version..
>
>   if (MBB.isEHPad())
>     LandingPads.push_back(&MBB);

LandingPads are the only thing that exists for x86_64 Linux while `catchswitch`, `catchpad`, and `cleanuppad` are all for Windows EH (https://llvm.org/docs/ExceptionHandling.html#new-exception-handling-instructions). Without proper testing on Windows I'd advocate for keeping it to LandingPads only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142747/new/

https://reviews.llvm.org/D142747