[PATCH] D142747: [Pseudo Probe] Do not instrument EH blocks.

Fri Jan 27 12:19:13 PST 2023

modimo added a comment.

In D142747#4087043 <https://reviews.llvm.org/D142747#4087043>, @hoy wrote:

> In D142747#4086978 <https://reviews.llvm.org/D142747#4086978>, @modimo wrote:
>
>> We've got the same EH-ness propagation code in MFS already: https://reviews.llvm.org/D131824. Consider merging the code?
>
> Oh I just remembered that code. They're basically the same algorithm. But given that IR and MIR routines are usually implemented separately otherwise templated code would be needed, I'd like to keep as is. WDYT?

I'm okay either way. That being said, all of BFI is templated on BB and MBB:

  template <class BT> class BlockFrequencyInfoImpl : BlockFrequencyInfoImplBase {

Given there's precedence and how identical the code I think it makes sense to combine them so they can't get out of sync.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142747/new/

https://reviews.llvm.org/D142747