[PATCH] D141874: [InstCombine] Add tests for reoredering (shift (add (shift x, C0), y), C1); NFC

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/InstCombine/shift-logic.ll:379
+
+define i8 @lshr_add(i8 %x, i8 %y) {
+; CHECK-LABEL: @lshr_add(
----------------
It would be good to add a "negative test" comment to this set of tests (and the corresponding sub variants) in D141875. 

That way, it's clear that if they get changed somehow in a subsequent patch, it's probably a miscompile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141874/new/

https://reviews.llvm.org/D141874