[PATCH] D142747: [Pseudo Probe] Do not instrument EH blocks.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D142747#4086745 <https://reviews.llvm.org/D142747#4086745>, @wlei wrote:

> Will this affect PROFI? if we don't insert probe for EH block, does PROFI assign a cold(0) value to the BB or leave it with an unknown value like the dangling probe?

Yes, it will affect Profi. The effect is just like removing those EH blocks from the IR. No corresponding counters (even 0) will show up in the profile. Profi can somehow deal with it smartly: https://github.com/llvm/llvm-project/blob/61eb12e1f423063b0ead944827dc53b02baed0d4/llvm/include/llvm/Transforms/Utils/SampleProfileInference.h#L294.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142747/new/

https://reviews.llvm.org/D142747