[PATCH] D142725: [DFAJumpThreading] Enable DFAJT with LTO

Fri Jan 27 09:08:32 PST 2023

martong added a comment.

In D142725#4085940 <https://reviews.llvm.org/D142725#4085940>, @nikic wrote:

> @martong Would the optimization also work if `-Xclang -enable-dfa-jump-thread` were specified in `CFLAGS` instead? If "yes", then I'd say this is firmly in the realm of user error and we should not make this change.

Yes, that would work with `-mllvm -enable-dfa-jump-thread`. And the Coremark score is roughly the same (within measurement error). I agree that it would be better if the user added the DFAJT optimization to CFLAGS rather then to the LDFLAGS, but do we really expect the users to have such a subtle knowledge about the opt passes? In particular, it might be surprising that this opt does not have any effect when it is used with LTO at the moment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142725/new/

https://reviews.llvm.org/D142725