[PATCH] D142708: [NFC] Transition GlobalObject alignment from MaybeAlign to Align

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 05:56:53 PST 2023


gchatelet added a comment.

@efriedma regarding the remaining calls, some of them will autosolve when `getAlign` will return `Align` instead of `MaybeAlign` but there are a few ones for which I'm unsure how to proceed.
More particularly the following ones that deal with creating new `GlobalObject`s. Is this reasonable to align to `1` when unknown or can we do better?

- llvm/lib/AsmParser/LLParser.cpp:1309 <https://github.com/llvm/llvm-project/blob/e195e6bad6706230a4b5fd4b5cc13de1f16f25cc/llvm/lib/AsmParser/LLParser.cpp#L1309>
- llvm/lib/AsmParser/LLParser.cpp:6050 <https://github.com/llvm/llvm-project/blob/e195e6bad6706230a4b5fd4b5cc13de1f16f25cc/llvm/lib/AsmParser/LLParser.cpp#L6050>
- llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3871 <https://github.com/llvm/llvm-project/blob/e195e6bad6706230a4b5fd4b5cc13de1f16f25cc/llvm/lib/Bitcode/Reader/BitcodeReader.cpp#L3871>
- llvm/lib/Bitcode/Reader/BitcodeReader.cpp:4030 <https://github.com/llvm/llvm-project/blob/e195e6bad6706230a4b5fd4b5cc13de1f16f25cc/llvm/lib/Bitcode/Reader/BitcodeReader.cpp#L4030>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142708/new/

https://reviews.llvm.org/D142708



More information about the llvm-commits mailing list