[PATCH] D142682: AMDGPU: Combine down fcopysign f64 magnitude

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 04:05:22 PST 2023


arsenm added a comment.

In D142682#4084919 <https://reviews.llvm.org/D142682#4084919>, @foad wrote:

> Looks OK but does it actually improve codegen? It is hard to tell from the diffs.

This mostly improves the cases involving constants. The actual width reduction is effectively what the codegen already, so there's a narrow range of second order improvements available from other combines


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142682/new/

https://reviews.llvm.org/D142682



More information about the llvm-commits mailing list