[PATCH] D142625: [IR][doc] Alignment is always set in memory for load/store/alloca/cmpxchg/atomicrmw.

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 02:07:48 PST 2023


gchatelet added a comment.

In D142625#4083421 <https://reviews.llvm.org/D142625#4083421>, @efriedma wrote:

> The phrasing isn't grammatically correct. I would say something like:
>
> "The alignment is only optional when parsing textual IR; for in-memory IR, it is always present."
>
> If you want to try to rearrange the text a bit, maybe put all discussion of the "optional-ness" of the alignment into a separate paragraph from the main definition of alignment.

Thx for the suggestion. I've reworded a bit, let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142625/new/

https://reviews.llvm.org/D142625



More information about the llvm-commits mailing list