[PATCH] D141429: [AArch64] Codegen for FEAT_LRCPC3

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 13:50:55 PST 2023


efriedma added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-load-rcpc3.ll:283
+; CHECK:    ldp x1, x0, [x0]
+; CHECK:    dmb ish
     %r = load atomic i128, ptr %ptr seq_cst, align 16
----------------
Sort of orthogonal to this change, but can someone at ARM verify if this is the sequence we actually want for sequentially consistent loads with lse2, as opposed to using caspal?  (I'm a bit concerned given the issues we ran into with narrower widths on Windows; see D141748.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141429/new/

https://reviews.llvm.org/D141429



More information about the llvm-commits mailing list