[PATCH] D140850: [InstCombine] Add optimizations for icmp eq/ne (mul(X, Y), 0)

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D140850#4083702 <https://reviews.llvm.org/D140850#4083702>, @nikic wrote:

> Implementation LGTM

Thanks, is `D140849` also good to push (as a general question, if there is a tests patch + a real patch, does real patch approval imply test patch approval).

In D140850#4083702 <https://reviews.llvm.org/D140850#4083702>, @nikic wrote:

> Implementation LGTM

Are the tests okay? Or do they need work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140850/new/

https://reviews.llvm.org/D140850