[lld] ae5efe9 - [lld] Remove transitional legacy pass manager flags
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 26 11:14:27 PST 2023
Author: Arthur Eubanks
Date: 2023-01-26T11:12:21-08:00
New Revision: ae5efe97618355e7552b0cb3c6790f3d8e8f8554
URL: https://github.com/llvm/llvm-project/commit/ae5efe97618355e7552b0cb3c6790f3d8e8f8554
DIFF: https://github.com/llvm/llvm-project/commit/ae5efe97618355e7552b0cb3c6790f3d8e8f8554.diff
LOG: [lld] Remove transitional legacy pass manager flags
Reviewed By: asbirlea
Differential Revision: https://reviews.llvm.org/D142571
Added:
Modified:
lld/COFF/Driver.cpp
lld/ELF/Options.td
lld/MachO/Options.td
lld/test/COFF/lto-new-pass-manager.ll
lld/test/ELF/lto/new-pass-manager.ll
lld/test/ELF/lto/slp-vectorize-pm.ll
lld/test/ELF/lto/verify-invalid.ll
lld/test/MachO/lto-objc-arc-contract.ll
lld/test/wasm/lto/new-pass-manager.ll
lld/test/wasm/lto/verify-invalid.ll
lld/wasm/Options.td
Removed:
################################################################################
diff --git a/lld/COFF/Driver.cpp b/lld/COFF/Driver.cpp
index 0a153c8f6cb79..edfa7f6167217 100644
--- a/lld/COFF/Driver.cpp
+++ b/lld/COFF/Driver.cpp
@@ -1761,8 +1761,6 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
tailMerge = 2;
} else if (s == "nolldtailmerge") {
tailMerge = 0;
- } else if (s == "ltonewpassmanager") {
- /* We always use the new PM. */
} else if (s == "ltodebugpassmanager") {
ltoDebugPM = true;
} else if (s == "noltodebugpassmanager") {
diff --git a/lld/ELF/Options.td b/lld/ELF/Options.td
index 09dc8c58a63ec..f9d02dbd436e2 100644
--- a/lld/ELF/Options.td
+++ b/lld/ELF/Options.td
@@ -554,8 +554,6 @@ def lto_debug_pass_manager: FF<"lto-debug-pass-manager">,
HelpText<"Debug new pass manager">;
def lto_emit_asm: FF<"lto-emit-asm">,
HelpText<"Emit assembly code">;
-def no_lto_legacy_pass_manager: FF<"no-lto-legacy-pass-manager">,
- HelpText<"Use the new pass manager in LLVM">;
def lto_newpm_passes: JJ<"lto-newpm-passes=">,
HelpText<"Passes to run during LTO">;
def lto_O: JJ<"lto-O">, MetaVarName<"<opt-level>">,
@@ -627,8 +625,6 @@ def plugin_opt_emit_llvm: F<"plugin-opt=emit-llvm">;
def: J<"plugin-opt=jobs=">, Alias<thinlto_jobs_eq>, HelpText<"Alias for --thinlto-jobs=">;
def: J<"plugin-opt=lto-partitions=">, Alias<lto_partitions>, HelpText<"Alias for --lto-partitions">;
def plugin_opt_mcpu_eq: J<"plugin-opt=mcpu=">;
-def: F<"plugin-opt=new-pass-manager">,
- Alias<no_lto_legacy_pass_manager>, HelpText<"Alias for --no-lto-legacy-pass-manager">;
def: F<"plugin-opt=cs-profile-generate">,
Alias<lto_cs_profile_generate>, HelpText<"Alias for --lto-cs-profile-generate">;
def: J<"plugin-opt=cs-profile-path=">,
diff --git a/lld/MachO/Options.td b/lld/MachO/Options.td
index f05835de040df..cb66f6277b5b5 100644
--- a/lld/MachO/Options.td
+++ b/lld/MachO/Options.td
@@ -53,9 +53,6 @@ def reproduce_eq: Joined<["--"], "reproduce=">,
def version: Flag<["--"], "version">,
HelpText<"Display the version number and exit">,
Group<grp_lld>;
-def no_lto_legacy_pass_manager : Flag<["--"], "no-lto-legacy-pass-manager">,
- HelpText<"Use the new pass manager in LLVM">,
- Group<grp_lld>;
def time_trace_eq: Joined<["--"], "time-trace=">,
HelpText<"Record time trace to <file>">,
MetaVarName<"<file>">,
diff --git a/lld/test/COFF/lto-new-pass-manager.ll b/lld/test/COFF/lto-new-pass-manager.ll
index 9e7b7f01b3e83..b210f34b60367 100644
--- a/lld/test/COFF/lto-new-pass-manager.ll
+++ b/lld/test/COFF/lto-new-pass-manager.ll
@@ -1,7 +1,7 @@
; REQUIRES: x86
; RUN: llvm-as %s -o %t.obj
-; RUN: lld-link %t.obj -entry:main -opt:ltonewpassmanager -opt:ltodebugpassmanager 2>&1 | FileCheck %s --check-prefix=ENABLED
+; RUN: lld-link %t.obj -entry:main -opt:ltodebugpassmanager 2>&1 | FileCheck %s --check-prefix=ENABLED
; ENABLED: Running pass: InstCombinePass
target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
diff --git a/lld/test/ELF/lto/new-pass-manager.ll b/lld/test/ELF/lto/new-pass-manager.ll
index 63ff4bef6821f..cc6ff34cd91ae 100644
--- a/lld/test/ELF/lto/new-pass-manager.ll
+++ b/lld/test/ELF/lto/new-pass-manager.ll
@@ -1,11 +1,9 @@
; REQUIRES: x86
; RUN: opt -module-summary %s -o %t.o
-; Test new-pass-manager and debug-pass-manager option
-; RUN: ld.lld --plugin-opt=new-pass-manager --plugin-opt=debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
-; RUN: ld.lld --plugin-opt=new-pass-manager --lto-debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
-; RUN: ld.lld --no-lto-legacy-pass-manager --plugin-opt=debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
-; RUN: ld.lld --no-lto-legacy-pass-manager --lto-debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
+; Test debug-pass-manager option
+; RUN: ld.lld --plugin-opt=debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
+; RUN: ld.lld --lto-debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s
; CHECK: Running pass: GlobalOptPass
diff --git a/lld/test/ELF/lto/slp-vectorize-pm.ll b/lld/test/ELF/lto/slp-vectorize-pm.ll
index 488f7b0f3d768..2171092569536 100644
--- a/lld/test/ELF/lto/slp-vectorize-pm.ll
+++ b/lld/test/ELF/lto/slp-vectorize-pm.ll
@@ -2,16 +2,16 @@
; RUN: opt -module-summary %s -o %t.o
; Test SLP and Loop Vectorization are enabled by default at O2 and O3.
-; RUN: ld.lld --plugin-opt=new-pass-manager --plugin-opt=debug-pass-manager --plugin-opt=O0 --plugin-opt=save-temps -shared -o %t1.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O0-SLP
+; RUN: ld.lld --plugin-opt=debug-pass-manager --plugin-opt=O0 --plugin-opt=save-temps -shared -o %t1.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O0-SLP
; RUN: llvm-dis %t.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-O0-LPV
-; RUN: ld.lld --plugin-opt=new-pass-manager --plugin-opt=debug-pass-manager --plugin-opt=O1 --plugin-opt=save-temps -shared -o %t2.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O1-SLP
+; RUN: ld.lld --plugin-opt=debug-pass-manager --plugin-opt=O1 --plugin-opt=save-temps -shared -o %t2.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O1-SLP
; RUN: llvm-dis %t.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-O1-LPV
-; RUN: ld.lld --plugin-opt=new-pass-manager --plugin-opt=debug-pass-manager --plugin-opt=O2 --plugin-opt=save-temps -shared -o %t3.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O2-SLP
+; RUN: ld.lld --plugin-opt=debug-pass-manager --plugin-opt=O2 --plugin-opt=save-temps -shared -o %t3.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O2-SLP
; RUN: llvm-dis %t.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-O2-LPV
-; RUN: ld.lld --plugin-opt=new-pass-manager --plugin-opt=debug-pass-manager --plugin-opt=O3 --plugin-opt=save-temps -shared -o %t4.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O3-SLP
+; RUN: ld.lld --plugin-opt=debug-pass-manager --plugin-opt=O3 --plugin-opt=save-temps -shared -o %t4.o %t.o 2>&1 | FileCheck %s --check-prefix=CHECK-O3-SLP
; RUN: llvm-dis %t.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-O3-LPV
; CHECK-O0-SLP-NOT: Running pass: SLPVectorizerPass
diff --git a/lld/test/ELF/lto/verify-invalid.ll b/lld/test/ELF/lto/verify-invalid.ll
index a07048407bf83..d97d0e1b78b8c 100644
--- a/lld/test/ELF/lto/verify-invalid.ll
+++ b/lld/test/ELF/lto/verify-invalid.ll
@@ -1,10 +1,10 @@
; REQUIRES: x86
; RUN: llvm-as %s -o %t.o
-; RUN: ld.lld %t.o -o %t2 --no-lto-legacy-pass-manager --lto-debug-pass-manager \
+; RUN: ld.lld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: 2>&1 | FileCheck -check-prefix=DEFAULT-NPM %s
-; RUN: ld.lld %t.o -o %t2 --no-lto-legacy-pass-manager --lto-debug-pass-manager \
+; RUN: ld.lld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: -disable-verify 2>&1 | FileCheck -check-prefix=DISABLE-NPM %s
-; RUN: ld.lld %t.o -o %t2 --no-lto-legacy-pass-manager --lto-debug-pass-manager \
+; RUN: ld.lld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: --plugin-opt=disable-verify 2>&1 | FileCheck -check-prefix=DISABLE-NPM %s
target triple = "x86_64-unknown-linux-gnu"
diff --git a/lld/test/MachO/lto-objc-arc-contract.ll b/lld/test/MachO/lto-objc-arc-contract.ll
index 5392c897469cd..e35985bdbdd80 100644
--- a/lld/test/MachO/lto-objc-arc-contract.ll
+++ b/lld/test/MachO/lto-objc-arc-contract.ll
@@ -5,11 +5,11 @@
;; which doesn't know how to handle it.
; RUN: llvm-as %s -o %t.o
-; RUN: %lld -dylib -lSystem %t.o -o %t --no-lto-legacy-pass-manager
+; RUN: %lld -dylib -lSystem %t.o -o %t
; RUN: llvm-objdump -d %t | FileCheck %s
; RUN: opt -module-summary %s -o %t.o
-; RUN: %lld -dylib -lSystem %t.o -o %t --no-lto-legacy-pass-manager
+; RUN: %lld -dylib -lSystem %t.o -o %t
; RUN: llvm-objdump -d %t | FileCheck %s
; CHECK: <_foo>:
diff --git a/lld/test/wasm/lto/new-pass-manager.ll b/lld/test/wasm/lto/new-pass-manager.ll
index 2e8908226ee22..377b31674ccc7 100644
--- a/lld/test/wasm/lto/new-pass-manager.ll
+++ b/lld/test/wasm/lto/new-pass-manager.ll
@@ -1,5 +1,5 @@
; RUN: llvm-as -o %t.bc %s
-; RUN: wasm-ld --no-lto-legacy-pass-manager --lto-debug-pass-manager -o /dev/null %t.bc 2>&1 | FileCheck %s
+; RUN: wasm-ld --lto-debug-pass-manager -o /dev/null %t.bc 2>&1 | FileCheck %s
; CHECK: Running pass: GlobalOptPass
diff --git a/lld/test/wasm/lto/verify-invalid.ll b/lld/test/wasm/lto/verify-invalid.ll
index 9e9026b586ccf..67ed5b5498f47 100644
--- a/lld/test/wasm/lto/verify-invalid.ll
+++ b/lld/test/wasm/lto/verify-invalid.ll
@@ -1,7 +1,7 @@
; RUN: llvm-as %s -o %t.o
-; RUN: wasm-ld %t.o -o %t2 --no-lto-legacy-pass-manager --lto-debug-pass-manager \
+; RUN: wasm-ld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: 2>&1 | FileCheck -check-prefix=DEFAULT-NPM %s
-; RUN: wasm-ld %t.o -o %t2 --no-lto-legacy-pass-manager --lto-debug-pass-manager \
+; RUN: wasm-ld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: -disable-verify 2>&1 | FileCheck -check-prefix=DISABLE-NPM %s
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
diff --git a/lld/wasm/Options.td b/lld/wasm/Options.td
index 2871ae6d576be..a47c852148d4c 100644
--- a/lld/wasm/Options.td
+++ b/lld/wasm/Options.td
@@ -265,8 +265,6 @@ def thinlto_cache_dir: JJ<"thinlto-cache-dir=">,
defm thinlto_cache_policy: EEq<"thinlto-cache-policy", "Pruning policy for the ThinLTO cache">;
def thinlto_jobs: JJ<"thinlto-jobs=">,
HelpText<"Number of ThinLTO jobs. Default to --threads=">;
-def no_lto_legacy_pass_manager: FF<"no-lto-legacy-pass-manager">,
- HelpText<"Use new pass manager">;
def lto_debug_pass_manager: FF<"lto-debug-pass-manager">,
HelpText<"Debug new pass manager">;
More information about the llvm-commits
mailing list