[PATCH] D142557: [mlir][Linalg] Fix crash when converting rank-reduced tensor.insert_slice

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar added inline comments.
Herald added a subscriber: thopre.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Utils/Utils.h:139
 std::optional<SmallVector<ReassociationIndices>>
-getReassociationMapForFoldingUnitDims(ArrayRef<OpFoldResult> mixedSizes);
+getReassociationMapForFoldingUnitDims(ArrayRef<OpFoldResult> mixedSizes,
+                                      bool insert = false);
----------------
Could you document what the `insert` argument is doing. I am not following whats happening here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142557/new/

https://reviews.llvm.org/D142557