[PATCH] D138202: [OHOS] Add support for OpenHarmony

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:250
     MacABI, // Mac Catalyst variant of Apple's iOS deployment target.
-    
     // Shader Stages
----------------
Keep blank line


================
Comment at: llvm/include/llvm/ADT/Triple.h:270
     Amplification,
-
-    LastEnvironmentType = Amplification
----------------
Keep blank line


================
Comment at: llvm/include/llvm/ADT/Triple.h:742
+  /// LiteOS default enviroment is also OHOS, but omited on triple.
+  bool isOHOSFamily() const { return isOpenHOS() || isOSLiteOS(); }
+
----------------
arsenm wrote:
> As someone who's never heard of this operating system, this helper name isn't particularly enlightening
What if I give aarch64-liteos-gnu?


================
Comment at: llvm/include/llvm/BinaryFormat/MinidumpConstants.def:118
 HANDLE_MDMP_PLATFORM(0x8205, NaCl) // Native Client (NaCl)
+HANDLE_MDMP_PLATFORM(0x8207, OpenHOS)
 
----------------
What's with the 0x8206 gap?


================
Comment at: llvm/test/Transforms/SafeStack/AArch64/abi.ll:2
 ; RUN: opt -safe-stack -S -mtriple=aarch64-linux-android < %s -o - | FileCheck %s
+; RUN: opt -safe-stack -S -mtriple=aarch64-linux-ohos < %s -o - | FileCheck %s --check-prefix=OHOS
 
----------------
These diffs don't belong here, the tests pass without them


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138202/new/

https://reviews.llvm.org/D138202