[PATCH] D142188: [ORC] Fix in-process lookup of symbols without GlobalPrefix

Thu Jan 26 07:45:57 PST 2023

Hahnfeld added a comment.
Herald added a subscriber: thopre.

Ok, understood. I think this should already be taken care of by the last update from Tuesday.

In D142188#4077734 <https://reviews.llvm.org/D142188#4077734>, @lhames wrote:

> As mentione, a good option for now would be to replace GlobalPrefix with a unique_function that takes a SymbolStringPtr and produces an optionally demangled string suitable for the platform's dynamic-symbol-lookup API.

I don't like this, we don't want every user of `DynamicLibrarySearchGenerator` to write their own demangler.

> Alternatively, maybe it's time to just add a DataLayout (or global default mangling and demangling functions) to `ExecutionSession` and let everybody reference that.

We could, but it seems to work fine with an additional `bool`. Alternatively, we could just always treat `'?'` special at the beginning. Let me know.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142188/new/

https://reviews.llvm.org/D142188