[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 06:57:40 PST 2023


tmatheson accepted this revision.
tmatheson added a comment.
This revision is now accepted and ready to land.

Looks great, thanks



================
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:338
+
+  uint64_t getDefaultExtensions() const {
+    return DefaultExtensions | Arch.DefaultExts;
----------------
nit: I would expect `getDefaultExtensions()` to return the value of `DefaultExtensions`. Is there a better naming combo we could use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142540/new/

https://reviews.llvm.org/D142540



More information about the llvm-commits mailing list