[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 05:49:11 PST 2023


tmatheson added inline comments.


================
Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456
+  std::optional<AArch64::ExtensionInfo> Extension =
+      AArch64::parseArchExtension(ArchExt);
+  if (!Extension)
----------------
I think we still need to test getDefaultExtensions, unless we're deleting it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142539/new/

https://reviews.llvm.org/D142539



More information about the llvm-commits mailing list