[PATCH] D139552: [NFC] Optimize vector usage in lld

[Andrew Ng via Phabricator via llvm-commits]

andrewng added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:1711
+    if (!isAlnum(c))
+      c = '_';
 
----------------
Just saw this in passing, I think `c` needs to be a reference as the intention is to change the character in `s`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139552/new/

https://reviews.llvm.org/D139552