[PATCH] D142545: [ConstraintElimination] Add tests to check for `or` instruction decomposition if a constant operand is < 2^known_zero_bits of the first operand.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/ConstraintElimination/or.ll:435
+
+define void @test.not.uge.ult(i8 %init_val, i8 %low, i8 %high) {
+; CHECK-LABEL: @test.not.uge.ult(
----------------
The names need updating I think to be more descriptive? There's just a single condition here and it would be good to make clear this tests `or -> add` conversion.


================
Comment at: llvm/test/Transforms/ConstraintElimination/or.ll:467
+
+if.then:                                          ; preds = %entry
+  ret void
----------------
Maybe call the blocks just `then` and `else`?

Also, it would be good to add some checks in this block too, to make sure they don't get optimized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142545/new/

https://reviews.llvm.org/D142545