[PATCH] D142567: DAG: Remove hasBitPreservingFPLogic

Thu Jan 26 03:43:24 PST 2023

arsenm added a comment.

In D142567#4080807 <https://reviews.llvm.org/D142567#4080807>, @spatel wrote:

> For reference, I added this hook with:
> https://reviews.llvm.org/D19391
> ...which was responding to:
> https://lists.llvm.org/pipermail/llvm-dev/2016-April/098098.html
> and:
> https://bugs.llvm.org/show_bug.cgi?id=24886#c4
>
> So there were problems before we had fneg/fabs in IR/SDAG, but it seems there were also problems with denorms and other edge cases. 
> I'm not opposed to this patch, but I think we should notify a wider audience about the change (since the hook defaulted to "off"). Out-of-tree targets may need to make adjustments. Post a message on discourse?

I don't think anyone notices those kinds of notices, but I posted https://discourse.llvm.org/t/notice-to-out-of-tree-targets-targetlowering-hasbitpreservingfplogic-is-being-removed/67975

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142567/new/

https://reviews.llvm.org/D142567