[PATCH] D142481: [DAGCombine] fp_to_sint isSaturatingMinMax
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 26 03:31:44 PST 2023
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/include/llvm/ADT/APFloat.h:249
static unsigned int semanticsSizeInBits(const fltSemantics &);
+ static unsigned int semanticsIntSizeInBits(const fltSemantics&, bool);
----------------
Maybe add a variable name IsSigned to the bool to make it more obvious?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142481/new/
https://reviews.llvm.org/D142481
More information about the llvm-commits
mailing list