[PATCH] D142445: [mlir][tensor|memref] Harden the checks on dim op

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi @mehdi_amini,

After talking with @aartbik and sleeping on it, I think making 0-ranked dim op invalid makes sense. I don't believe we can produce them with optimizations.

Regarding the out-of-bound accesses for the non-0-ranked shapes, I will do a separate patch to remove the verifier checks and do something sensible (unreachable, ..., anything but crash).
Thanks for filing the issue BTW.

What do you think?

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142445/new/

https://reviews.llvm.org/D142445