[PATCH] D142418: AMDGPU: Teach fneg combines that select has source modifiers

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

Do we have/want something like this in GISel?



================
Comment at: llvm/test/CodeGen/AMDGPU/fmin_fmax_legacy.amdgcn.ll:1
 ; RUN: llc -march=amdgcn < %s | FileCheck -enable-var-scope -check-prefixes=SI-SAFE,GCN %s
+; RUN: llc -enable-no-nans-fp-math -enable-no-signed-zeros-fp-math -march=amdgcn < %s | FileCheck -enable-var-scope --check-prefixes=GCN %s
----------------
It would be nice for those tests to be autogenerated to make them easier to update, make review easier and increase our testing coverage.
Is there a reason why we have some manual tests like these?

In any case it's not for this diff but I've been wondering about this. If I have some time maybe I can make diffs to autogenerate a few of them because it can be a bit annoying sometimes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142418/new/

https://reviews.llvm.org/D142418