[llvm] d4e3a1d - Revert "Fix compilation failure in CoverageMapping.cpp"

Douglas Yung via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 19:12:41 PST 2023


Author: Douglas Yung
Date: 2023-01-25T19:10:29-08:00
New Revision: d4e3a1dcf6494874c1cc4f180c780641593d2ab0

URL: https://github.com/llvm/llvm-project/commit/d4e3a1dcf6494874c1cc4f180c780641593d2ab0
DIFF: https://github.com/llvm/llvm-project/commit/d4e3a1dcf6494874c1cc4f180c780641593d2ab0.diff

LOG: Revert "Fix compilation failure in CoverageMapping.cpp"

This reverts commit 46013fc10a6879f4c9b4c9b9fbd43e4dc70f3c8b.

The original commit efbc8bb18eda63007216ad0cb5a8de04963eddd5 is failing on several bots, so
reverting this follow-up commit as well as the original commit.

Added: 
    

Modified: 
    llvm/lib/ProfileData/Coverage/CoverageMapping.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
index 9e3a3d7ba40fc..52cb577fef101 100644
--- a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
+++ b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
@@ -406,7 +406,7 @@ CoverageMapping::load(ArrayRef<StringRef> ObjectFilenames,
     if (Error E =
             loadFromFile(File.value(), GetArch(File.index()), CompilationDir,
                          *ProfileReader, *Coverage, DataFound, &FoundBinaryIDs))
-      return std::move(E);
+      return E;
   }
 
   if (BIDFetcher) {
@@ -438,7 +438,7 @@ CoverageMapping::load(ArrayRef<StringRef> ObjectFilenames,
       StringRef Arch = Arches.size() == 1 ? Arches.front() : StringRef();
       if (Error E = loadFromFile(Path, Arch, CompilationDir, *ProfileReader,
                                  *Coverage, DataFound))
-        return std::move(E);
+        return E;
     }
   }
 


        


More information about the llvm-commits mailing list