[PATCH] D131813: [BOLT][NFC] Move addRelocation{X86,AArch64} into MCPlusBuilder

Wed Jan 25 17:09:16 PST 2023

Amir added inline comments.

================
Comment at: bolt/include/bolt/Core/MCPlusBuilder.h:399
+  /// Return true if the relocation type is supported
+  virtual bool isSupportedRelocation(uint64_t RelType) const {
+    llvm_unreachable("not implemented");
----------------
rafauler wrote:
> I'm a bit confused with the name, for example, what does it mean to have a supported relocation? Why is ELF::R_AARCH64_CALL26 unsupported? I think either the comments here need to be expanded a bit or the function get a better name, because this "support" is very specific to the needs of BinaryFunction.
What name and comment would you suggest? These are relocations we store for function splitting and reordering.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131813/new/

https://reviews.llvm.org/D131813