[PATCH] D141836: [AArch64] Disable __muloti4 libcalls for AArch64

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In D141836#4080877 <https://reviews.llvm.org/D141836#4080877>, @cjdb wrote:

> +1 to trying to add these to libgcc instead of removing from compiler-rt.

To be clear, no one is suggesting to remove this from compiler-rt, just not enable by default for LLVM lowering on AArch64. Very different things.

There are some Linux distros and FreeBSD who do the same thing, and they'd also be affected. But since this is a build issue, we could work around it by some build flag or triple check that enables it.

> there's no reason why it couldn't be added as well. Has anyone tried?

Honestly, I don't know, and am still a little surprised that it's still not there yet...

But the main problem back then, and is still relevant now, is that adding it to libgcc won't fix for the previous versions, which will be available for years on distros, builds, etc.

I think this is an orthogonal issue. Sure, it would be nice to have that in libgcc, and it would eventually fix the problem, but it wouldn't make a difference today.

I'm also surprised that this is still the only (?) case where we have that kind of a problem. I'd expect it to be more widespread...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141836/new/

https://reviews.llvm.org/D141836