[PATCH] D142519: [KnownBits] Add blsi and blsmsk
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 25 11:03:26 PST 2023
goldstein.w.n added a comment.
In D142519#4079179 <https://reviews.llvm.org/D142519#4079179>, @foad wrote:
> Personally I still think this is too much extra complexity for uncertain benefit, but I won't stand in the way if the other reviewers are happy.
>
> In any case the comments need work and the new functions should have exhaustive tests.
Do the overloaded `blsmsk` functions need exhaustive? They are unimplemented. Just think its
easier to design the full API now in case it ever becomes desired.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142519/new/
https://reviews.llvm.org/D142519
More information about the llvm-commits
mailing list