[PATCH] D140180: [llvm] add CallBrPrepare pass to pipelines

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 09:23:56 PST 2023


efriedma added inline comments.


================
Comment at: llvm/docs/LangRef.rst:8537
+To support outputs along indirect edges, LLVM may need to split critical edges.
+This means that basic blocks may be synthesized; ``indirect labels`` from
+inline asm may not compare equal to the label when passed as a
----------------
Labels aren't a thing in LLVM IR; if you mean "blockaddress", please state that explicitly.  Otherwise, I'm not sure what you're referring to.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:632
+          !MBB->isInlineAsmBrIndirectTarget()) {
+        report("MBB has allocatable live-in, but isn't entry, landing-pad, or inlineasm-br-indirect-target.", MBB);
         report_context(LI.PhysReg);
----------------
80 cols?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140180/new/

https://reviews.llvm.org/D140180



More information about the llvm-commits mailing list