[PATCH] D142308: [Polly] Fix a if condition in isl_coalesce.ci

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Thank you for the patch. However, we do not patch ISL in the LLVM directly, but instead report upstream to isl-development at googlegroups.com and then update the LLVM copy.

I think this has already been fixed upstream in https://repo.or.cz/isl.git/blobdiff/f7b0ef95845d57fc839090d5075b84fa706eeb15..f035f41be325a5e173d6531f384ded9799943d87:/isl_coalesce.c . I just updated the LLVM copy. The funcion now reads

  	if (any) {
  		if (isl_tab_rollback(info->tab, snap) < 0)
  			return isl_stat_error;
  		info->bmap = isl_basic_map_cow(info->bmap);
  		info->bmap = isl_basic_map_free_inequality(info->bmap, 2 * n);
  		if (!info->bmap)
  			return isl_stat_error;
  
  		return fix_constant_divs(info, n, expanded);
  	}

Please check whether the problem still occurs. I cannot check without a test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142308/new/

https://reviews.llvm.org/D142308