[PATCH] D142549: [AMDGPU] Make flat_offset a 32-bit operand instead of 16-bits

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 08:43:38 PST 2023


foad accepted this revision.
foad added a comment.

Thanks!



================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:144
 
+    const unsigned OffsetSize = AMDGPU::getNumFlatOffsetBits(STI, !IsFlatSeg);
     if (IsFlatSeg) { // Unsigned offset
----------------
foad wrote:
> Nit: sink this into the "else" part?
You can remove the braces too now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142549/new/

https://reviews.llvm.org/D142549



More information about the llvm-commits mailing list