[PATCH] D142548: [AArch64] Replace AEK_CRYPTO with relevant features in cpu definitions

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 08:00:03 PST 2023


dmgreen created this revision.
dmgreen added reviewers: ilinpv, danielkiss, DavidSpickett, ostannard, efriedma, tmatheson, lenary, pratlucas.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

This replaces `AEK_CRYPTO` in the AArch64TargetParser definitions, replacing the composite Crypto features with the constituent parts. `AEK_CRYPTO` is replaced with either `AEK_AES | AEK_SHA2` or `AEK_AES | AEK_SHA2 | AEK_SHA3 | AEK_SHA4` depending on if the cpu is Arm-v8.4+. This helps get the features correct in some more places like `target("cpu=..")` attributes.

Otherwise this is hopefully an NFC for -mcpu options but seems like a cleaner design.


https://reviews.llvm.org/D142548

Files:
  clang/lib/Driver/ToolChains/Arch/AArch64.cpp
  clang/test/CodeGen/aarch64-targetattr-crypto.c
  clang/test/CodeGen/aarch64-targetattr.c
  clang/test/Preprocessor/aarch64-target-features.c
  llvm/include/llvm/TargetParser/AArch64TargetParser.h
  llvm/unittests/TargetParser/TargetParserTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142548.492110.patch
Type: text/x-patch
Size: 81705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230125/3321de60/attachment-0001.bin>


More information about the llvm-commits mailing list