[PATCH] D142431: [extract_symbols.py] Filter out more symbols for MSVC

[John Brawn via Phabricator via llvm-commits]

john.brawn added inline comments.


================
Comment at: llvm/utils/extract_symbols.py:146
+        # Discard floating point/SIMD constants.
+        if symbol.startswith(("__xmm@", "__real@")):
+            return None
----------------
I think we can also discard __ymm symbols here (from looking at llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp).


================
Comment at: llvm/utils/extract_symbols.py:171
         return None
+    # Skip X86GenMnemonicTables functions.
+    elif re.match('\?is[A-Z0-9]*@X86 at llvm', symbol):
----------------
Could you add something to the comment here saying why discarding these symbols is a valid thing to do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142431/new/

https://reviews.llvm.org/D142431