[PATCH] D142532: [SPIRV] Fix build warnings

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 04:04:15 PST 2023


foad created this revision.
Herald added subscribers: StephenFan, ThomasRaoux, hiraditya.
Herald added a project: All.
foad requested review of this revision.
Herald added a reviewer: zuban32.
Herald added a reviewer: mpaszkowski.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix these build warnings:

SPIRVBuiltins.cpp:1590:30: warning: 'getPrefTypeAlignment' is deprecated: use getPrefTypeAlign instead [-Wdeprecated-declarations]
SPIRVUtils.cpp:209:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142532

Files:
  llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
  llvm/lib/Target/SPIRV/SPIRVUtils.cpp


Index: llvm/lib/Target/SPIRV/SPIRVUtils.cpp
===================================================================
--- llvm/lib/Target/SPIRV/SPIRVUtils.cpp
+++ llvm/lib/Target/SPIRV/SPIRVUtils.cpp
@@ -206,7 +206,6 @@
   case AtomicOrdering::Unordered:
   case AtomicOrdering::Monotonic:
   case AtomicOrdering::NotAtomic:
-  default:
     return SPIRV::MemorySemantics::None;
   }
 }
Index: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
===================================================================
--- llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
+++ llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
@@ -1587,7 +1587,7 @@
   MIB.addUse(buildConstantIntReg(DL.getTypeStoreSize(PType), MIRBuilder, GR));
   // Param Aligment: Aligment of block literal structure.
   MIB.addUse(
-      buildConstantIntReg(DL.getPrefTypeAlignment(PType), MIRBuilder, GR));
+      buildConstantIntReg(DL.getPrefTypeAlign(PType).value(), MIRBuilder, GR));
 
   for (unsigned i = 0; i < LocalSizes.size(); i++)
     MIB.addUse(LocalSizes[i]);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142532.492058.patch
Type: text/x-patch
Size: 1004 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230125/4a92b0df/attachment-0001.bin>


More information about the llvm-commits mailing list