[llvm] 29e9022 - [gold] Remove no-opaque-pointers option

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2023-01-25T12:26:57+01:00
New Revision: 29e9022fe8f08ebf33452eda1090b1fbc7a0cdf7

URL: https://github.com/llvm/llvm-project/commit/29e9022fe8f08ebf33452eda1090b1fbc7a0cdf7
DIFF: https://github.com/llvm/llvm-project/commit/29e9022fe8f08ebf33452eda1090b1fbc7a0cdf7.diff

LOG: [gold] Remove no-opaque-pointers option

The opaque-pointers option is retained as a no-op, same as with
new-pass-manager.

Added: 
    

Modified: 
    llvm/tools/gold/gold-plugin.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/gold/gold-plugin.cpp b/llvm/tools/gold/gold-plugin.cpp
index 939dbaf06b04c..90146fbe8df25 100644
--- a/llvm/tools/gold/gold-plugin.cpp
+++ b/llvm/tools/gold/gold-plugin.cpp
@@ -208,8 +208,6 @@ namespace options {
   static std::string stats_file;
   // Asserts that LTO link has whole program visibility
   static bool whole_program_visibility = false;
-  // Use opaque pointer types.
-  static bool opaque_pointers = true;
 
   // Optimization remarks filename, accepted passes and hotness options
   static std::string RemarksFilename;
@@ -311,9 +309,7 @@ namespace options {
     } else if (opt.consume_front("stats-file=")) {
       stats_file = std::string(opt);
     } else if (opt == "opaque-pointers") {
-      opaque_pointers = true;
-    } else if (opt == "no-opaque-pointers") {
-      opaque_pointers = false;
+      // We always use opaque pointers.
     } else {
       // Save this option to pass to the code generator.
       // ParseCommandLineOptions() expects argv[0] to be program name. Lazily
@@ -960,8 +956,6 @@ static std::unique_ptr<LTO> createLTO(IndexWriteCallback OnIndexWrite,
 
   Conf.HasWholeProgramVisibility = options::whole_program_visibility;
 
-  Conf.OpaquePointers = options::opaque_pointers;
-
   Conf.StatsFile = options::stats_file;
   return std::make_unique<LTO>(std::move(Conf), Backend,
                                 options::ParallelCodeGenParallelismLevel);