[PATCH] D142429: [InstCombine] Use `analyzeKnownBitsFromAndXorOr` in `SimplifyDemandedUseBits` for and/xor/or

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 03:01:19 PST 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:198
 
-    Known = LHSKnown & RHSKnown;
+    if (const Operator *Op = dyn_cast<Operator>(I))
+      Known = analyzeKnownBitsFromAndXorOr(Op, LHSKnown, RHSKnown, Depth, DL,
----------------
You can use `cast<Operator>(I)` here and drop the if. Every Instruction is an Operator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142429/new/

https://reviews.llvm.org/D142429



More information about the llvm-commits mailing list