[PATCH] D142498: [NFC] Prepare for new includes

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 19:54:51 PST 2023


scott.linder added a comment.

In D142498#4078797 <https://reviews.llvm.org/D142498#4078797>, @int3 wrote:

> I intentionally avoided including Codegen.h for this reason. Can we use forward declarations instead?

I didn't think so, but I wasn't certain why; I double checked and realized the prohibition on forward declaring enums only applies when the underlying type is not specified (i.e. the size isn't known).

I'll fix it tomorrow and drop this review; thank you for getting me to check again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142498/new/

https://reviews.llvm.org/D142498



More information about the llvm-commits mailing list