[PATCH] D142163: [LLD][ELF] Add --lto-export-symbol-list
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 24 15:49:26 PST 2023
MaskRay added a comment.
In D142163#4077996 <https://reviews.llvm.org/D142163#4077996>, @samitolvanen wrote:
> In D142163#4067630 <https://reviews.llvm.org/D142163#4067630>, @pcc wrote:
>
>> What do you think about making this apply not only to LTO but to other `-r` links as well?
>
> Sure, I'm fine with that. Looks like we would just have to apply `computeBinding` to relocatable links as well when export symbols are specified. @MaskRay, what do you think?
(On a trip; don't have much time checking emails or looking into patch details)
The feature applying to `-r` makes sense.
================
Comment at: lld/ELF/Symbols.h:175
bool includeInDynsym() const;
- uint8_t computeBinding() const;
+ uint8_t computeBinding(bool UseLTOExports = false) const;
bool isGlobal() const { return binding == llvm::ELF::STB_GLOBAL; }
----------------
wrong case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142163/new/
https://reviews.llvm.org/D142163
More information about the llvm-commits
mailing list